CVE-2021-47288: media: ngene: Fix out-of-bounds bug in ngene_command_config_free_buf()
First published: Tue May 21 2024(Updated: )
In the Linux kernel, the following vulnerability has been resolved: media: ngene: Fix out-of-bounds bug in ngene_command_config_free_buf() Fix an 11-year old bug in ngene_command_config_free_buf() while addressing the following warnings caught with -Warray-bounds: arch/alpha/include/asm/string.h:22:16: warning: '__builtin_memcpy' offset [12, 16] from the object at 'com' is out of the bounds of referenced subobject 'config' with type 'unsigned char' at offset 10 [-Warray-bounds] arch/x86/include/asm/string_32.h:182:25: warning: '__builtin_memcpy' offset [12, 16] from the object at 'com' is out of the bounds of referenced subobject 'config' with type 'unsigned char' at offset 10 [-Warray-bounds] The problem is that the original code is trying to copy 6 bytes of data into a one-byte size member _config_ of the wrong structue FW_CONFIGURE_BUFFERS, in a single call to memcpy(). This causes a legitimate compiler warning because memcpy() overruns the length of &com.cmd.ConfigureBuffers.config. It seems that the right structure is FW_CONFIGURE_FREE_BUFFERS, instead, because it contains 6 more members apart from the header _hdr_. Also, the name of the function ngene_command_config_free_buf() suggests that the actual intention is to ConfigureFreeBuffers, instead of ConfigureBuffers (which takes place in the function ngene_command_config_buf(), above). Fix this by enclosing those 6 members of struct FW_CONFIGURE_FREE_BUFFERS into new struct config, and use &com.cmd.ConfigureFreeBuffers.config as the destination address, instead of &com.cmd.ConfigureBuffers.config, when calling memcpy(). This also helps with the ongoing efforts to globally enable -Warray-bounds and get us closer to being able to tighten the FORTIFY_SOURCE routines on memcpy().
Credit: 416baaa9-dc9f-4396-8d5f-8c081fb06d67
| Affected Software | Affected Version | How to fix |
|---|---|---|
| Linux Linux kernel | >=2.6.34<4.4.277 | |
| Linux Linux kernel | >=4.5<4.9.277 | |
| Linux Linux kernel | >=4.10<4.14.241 | |
| Linux Linux kernel | >=4.15<4.19.199 | |
| Linux Linux kernel | >=4.20<5.4.136 | |
| Linux Linux kernel | >=5.5<5.10.54 | |
| Linux Linux kernel | >=5.11<5.13.6 | |
| Linux Linux kernel | =5.14-rc1 | |
| Linux Linux kernel | =5.14-rc2 |
Never miss a vulnerability like this again
Sign up to SecAlerts for real-time vulnerability data matched to your software, aggregated from hundreds of sources.
Reference Links
- https://git.kernel.org/stable/c/4487b968e5eacd02c493303dc2b61150bb7fe4b2
- https://git.kernel.org/stable/c/c6ddeb63dd543b5474b0217c4e47538b7ffd7686
- https://git.kernel.org/stable/c/e818f2ff648581a6c553ae2bebc5dcef9a8bb90c
- https://git.kernel.org/stable/c/ec731c6ef564ee6fc101fc5d73e3a3a953d09a00
- https://git.kernel.org/stable/c/e617fa62f6cf859a7b042cdd6c73af905ff8fca3
- https://git.kernel.org/stable/c/e991457afdcb5f4dbc5bc9d79eaf775be33e7092
- https://git.kernel.org/stable/c/b9a178f189bb6d75293573e181928735f5e3e070
- https://git.kernel.org/stable/c/8d4abca95ecc82fc8c41912fa0085281f19cc29f
- agent/references
- agent/title
- agent/description
- agent/first-publish-date
- agent/type
- agent/author
- agent/event
- collector/mitre-cve
- source/MITRE
- collector/nvd-api
- source/NVD
- agent/software-canonical-lookup
- agent/last-modified-date
- agent/severity
- agent/remedy
- agent/softwarecombine
- agent/tags
- agent/weakness
- vendor/linux
- canonical/linux linux kernel
- version/linux linux kernel/2.6.34
- version/linux linux kernel/4.5
- version/linux linux kernel/4.10
- version/linux linux kernel/4.15
- version/linux linux kernel/4.20
- version/linux linux kernel/5.5
- version/linux linux kernel/5.11
- version/linux linux kernel/5.14-rc1
- version/linux linux kernel/5.14-rc2