CVE-2022-23607: Unsafe handling of user-specified cookies in treq
First published: Tue Feb 01 2022(Updated: )
### Impact Treq's request methods (`treq.get`, `treq.post`, `HTTPClient.request`, `HTTPClient.get`, etc.) accept cookies as a dictionary, for example: ```py treq.get('https://example.com/', cookies={'session': '1234'}) ``` Such cookies are not bound to a single domain, and are therefore sent to *every* domain ("supercookies"). This can potentially cause sensitive information to leak upon an HTTP redirect to a different domain., e.g. should `https://example.com` redirect to `http://cloudstorageprovider.com` the latter will receive the cookie `session`. ### Patches Treq 2021.1.0 and later bind cookies given to request methods (`treq.request`, `treq.get`, `HTTPClient.request`, `HTTPClient.get`, etc.) to the origin of the *url* parameter. ### Workarounds Instead of passing a dictionary as the *cookies* argument, pass a `http.cookiejar.CookieJar` instance with properly domain- and scheme-scoped cookies in it: ```py from http.cookiejar import CookieJar from requests.cookies import create_cookie jar = CookieJar() jar.add_cookie( create_cookie( name='session', value='1234', domain='example.com', secure=True, ), ) client = HTTPClient(cookies=jar) client.get('https://example.com/') ``` ### References * Originally reported at [huntr.dev](https://huntr.dev/bounties/3c9204fc-a3d1-4441-8599-924c5f57e7ae/?token=06d930e37046c914bcb037e85cc227dc7b510b475989fc69837566562ba899277d46b0fb4b1e21cdcb6ddc1b7d9b1ded632cf3a3551ecb89afca16a63b34641284b50479d5195bba2ac09b116f3dd4fad27f54404c2de922c05c8c8b744aec27bb4d4d198cb8b3abf479af0c2d5fbaa10412da7922594ac3eb39) * A related issue in the handling of HTTP basic authentication was addressed in Twisted 22.1 ([GHSA-92x2-jw7w-xvvx](https://github.com/twisted/twisted/security/advisories/GHSA-92x2-jw7w-xvvx), CVE-2022-21712).
Credit: security-advisories@github.com security-advisories@github.com security-advisories@github.com
| Affected Software | Affected Version | How to fix |
|---|---|---|
| pip/treq | <22.1.0 | 22.1.0 |
| twistedmatrix treq | >=21.1.0<22.1.0 | |
| Debian GNU/Linux | =9.0 |
Never miss a vulnerability like this again
Sign up to SecAlerts for real-time vulnerability data matched to your software, aggregated from hundreds of sources.
Reference Links
- https://github.com/twisted/treq/security/advisories/GHSA-fhpf-pp6p-55qc
- https://lists.debian.org/debian-lts-announce/2022/03/msg00025.html
- https://github.com/twisted/treq/commit/1da6022cc880bbcff59321abe02bf8498b89efb2
- https://github.com/twisted/treq/releases/tag/release-22.1.0
- https://huntr.dev/bounties/3c9204fc-a3d1-4441-8599-924c5f57e7ae/?token=06d930e37046c914bcb037e85cc227dc7b510b475989fc69837566562ba899277d46b0fb4b1e21cdcb6ddc1b7d9b1ded632cf3a3551ecb89afca16a63b34641284b50479d5195bba2ac09b116f3dd4fad27f54404c2de922c05c8c8b744aec27bb4d4d198cb8b3abf479af0c2d5fbaa10412da7922594ac3eb39
- https://nvd.nist.gov/vuln/detail/CVE-2022-23607
- https://github.com/advisories/GHSA-fhpf-pp6p-55qc (Advisory)
- https://github.com/pypa/advisory-database/tree/main/vulns/treq/PYSEC-2022-26.yaml
Frequently Asked Questions
What is CVE-2022-23607?
CVE-2022-23607 is a high severity vulnerability in the treq HTTP library that allows cookies to be sent to every domain instead of a single domain.
How does CVE-2022-23607 affect Twistedmatrix Treq?
Twistedmatrix Treq versions between 21.1.0 and 22.1.0 are affected by CVE-2022-23607.
How does CVE-2022-23607 affect Debian Debian Linux?
Debian Debian Linux version 9.0 is affected by CVE-2022-23607.
What is the severity of CVE-2022-23607?
CVE-2022-23607 has a severity rating of 7.4 (high).
How can I fix CVE-2022-23607?
To fix CVE-2022-23607, upgrade Twistedmatrix Treq to a version above 22.1.0 or apply the necessary security patches for Debian Debian Linux 9.0.
- agent/type
- agent/weakness
- agent/severity
- agent/description
- agent/first-publish-date
- agent/author
- collector/mitre-cve
- source/MITRE
- agent/title
- agent/event
- collector/github-advisory-latest
- source/GitHub
- alias/GHSA-fhpf-pp6p-55qc
- alias/CVE-2022-23607
- agent/software-canonical-lookup
- agent/last-modified-date
- agent/references
- collector/github-advisory
- agent/trending
- agent/source
- collector/nvd-cve
- source/NVD
- agent/software-canonical-lookup-request
- agent/softwarecombine
- agent/tags
- collector/nvd-api
- collector/nvd-index
- package-manager/pip
- vendor/twistedmatrix
- canonical/twistedmatrix treq
- version/twistedmatrix treq/21.1.0
- vendor/debian
- canonical/debian gnu/linux
- version/debian gnu/linux/9.0