CVE-2023-32309: Arbitrary file inclusion with the pymdowm-snippets extension
Summary
Arbitrary file read when using include file syntax.
Details
By using the syntax --8<--"/etc/passwd" or --8<--"/proc/self/environ" the content of these files will be rendered in the generated documentation. Additionally, a path relative to a specified, allowed base path can also be used to render the content of a file outside the specified base paths: --8<-- "../../../../etc/passwd".
Within the Snippets extension, there exists a basepath option but the implementation is vulnerable to Directory Traversal. The vulnerable section exists in getsnippetpath(self, path) lines 155 to 174 in snippets.py.
base = "docs" path = "/etc/passwd" filename = os.path.join(base,path) # Filename is now /etc/passwd
PoC
py import markdown
payload = "--8<-- \"/etc/passwd\"" html = markdown.markdown(payload, extensions=['pymdownx.snippets'])
print(html)
Impact
Any readable file on the host where the plugin is executing may have its content exposed. This can impact any use of Snippets that exposes the use of Snippets to external users.
It is never recommended to use Snippets to process user-facing, dynamic content. It is designed to process known content on the backend under the control of the host, but if someone were to accidentally enable it for user-facing content, undesired information could be exposed.
Suggestion
Specified snippets should be restricted to the configured, specified base paths as a safe default. Allowing relative or absolute paths that escape the specified base paths would need to be behind a feature switch that must be opt-in and would be at the developer's own risk.
Other sources
PyMdown Extensions is a set of extensions for the Python-Markdown markdown project. In affected versions an arbitrary file read is possible when using include file syntax. By using the syntax --8<--"/etc/passwd" or --8<--"/proc/self/environ" the content of these files will be rendered in the generated documentation. Additionally, a path relative to a specified, allowed base path can also be used to render the content of a file outside the specified base paths: --8<-- "../../../../etc/passwd". Within the Snippets extension, there exists a basepath option but the implementation is vulnerable to Directory Traversal. The vulnerable section exists in getsnippetpath(self, path) lines 155 to 174 in snippets.py. Any readable file on the host where the plugin is executing may have its content exposed. This can impact any use of Snippets that exposes the use of Snippets to external users. It is never recommended to use Snippets to process user-facing, dynamic content. It is designed to process known content on the backend under the control of the host, but if someone were to accidentally enable it for user-facing content, undesired information could be exposed. This issue has been addressed in version 10.0. Users are advised to upgrade. Users unable to upgrade may restrict relative paths by filtering input.
— MITRE
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
pip/pymdown-extensionsto a version that resolves this vulnerability.Fixed in 10.0 - Upgrade
Upgrade
PyMdown Extensionsto a version that resolves this vulnerability.Fixed in 10.0 - Compensating control
If unable to upgrade, filter input to restrict relative paths and prevent paths from escaping the configured base paths.