CVE-2024-25129: Limited data exfiltration in CodeQL CLI
The CodeQL CLI repo holds binaries for the CodeQL command line interface (CLI). Prior to version 2.16.3, an XML parser used by the CodeQL CLI to read various auxiliary files is vulnerable to an XML External Entity attack. If a vulnerable version of the CLI is used to process either a maliciously modified CodeQL database, or a specially prepared set of QL query sources, the CLI can be made to make an outgoing HTTP request to an URL that contains material read from a local file chosen by the attacker. This may result in a loss of privacy of exfiltration of secrets. Security researchers and QL authors who receive databases or QL source files from untrusted sources may be impacted. A single untrusted .ql or .qll file cannot be affected, but a zip archive or tarball containing QL sources may unpack auxiliary files that will trigger an attack when CodeQL sees them in the file system. Those using CodeQL for routine analysis of source trees with a preselected set of trusted queries are not affected. In particular, extracting XML files from a source tree into the CodeQL database does not make one vulnerable. The problem is fixed in release 2.16.3 of the CodeQL CLI. Other than upgrading, workarounds include not accepting CodeQL databases or queries from untrusted sources, or only processing such material on a machine without an Internet connection. Customers who use older releases of CodeQL for security scanning in an automated CI system and cannot upgrade for compliance reasons can continue using that version. That use case is safe. If such customers have a private query pack and use the codeql pack create command to precompile them before using them in the CI system, they should be using the production CodeQL release to run codeql pack create. That command is safe as long as the QL source it precompiled is trusted. All other development of the query pack should use an upgraded CLI.
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
CodeQL CLIto a version that resolves this vulnerability.Fixed in 2.16.3 - Configuration
When precompiling a private query pack with the `codeql pack create` command (for use in an automated CI system), run `codeql pack create` using the production CodeQL release (safe as long as the QL source it precompiles is trusted).
codeql pack create use = production CodeQL release - Compensating control
Do not accept CodeQL databases or QL queries from untrusted sources; alternatively, only process such material on a machine without an Internet connection.
- Operational
If you previously processed maliciously modified CodeQL databases or specially prepared QL query sources using a vulnerable CodeQL CLI, assume limited data exfiltration of secrets may have occurred; rotate any exposed secrets/credentials.
Event History
Frequently Asked Questions
What is the severity of CVE-2024-25129?
CVE-2024-25129 has been classified with a medium severity due to its potential impact on XML External Entity attacks.
How do I fix CVE-2024-25129?
To fix CVE-2024-25129, update to CodeQL CLI version 2.16.3 or later.
What software is affected by CVE-2024-25129?
CVE-2024-25129 affects versions of GitHub CodeQL CLI prior to 2.16.3.
What kind of attack does CVE-2024-25129 facilitate?
CVE-2024-25129 facilitates an XML External Entity (XXE) attack on the CodeQL CLI.
What is the impact of exploiting CVE-2024-25129?
Exploiting CVE-2024-25129 could allow an attacker to access sensitive files and potentially execute arbitrary code.