Advisory Published
CVE Published
Updated

CVE-2024-26935: scsi: core: Fix unremoved procfs host directory regression

First published: Wed May 01 2024(Updated: )

In the Linux kernel, the following vulnerability has been resolved: scsi: core: Fix unremoved procfs host directory regression Commit fc663711b944 ("scsi: core: Remove the /proc/scsi/${proc_name} directory earlier") fixed a bug related to modules loading/unloading, by adding a call to scsi_proc_hostdir_rm() on scsi_remove_host(). But that led to a potential duplicate call to the hostdir_rm() routine, since it's also called from scsi_host_dev_release(). That triggered a regression report, which was then fixed by commit be03df3d4bfe ("scsi: core: Fix a procfs host directory removal regression"). The fix just dropped the hostdir_rm() call from dev_release(). But it happens that this proc directory is created on scsi_host_alloc(), and that function "pairs" with scsi_host_dev_release(), while scsi_remove_host() pairs with scsi_add_host(). In other words, it seems the reason for removing the proc directory on dev_release() was meant to cover cases in which a SCSI host structure was allocated, but the call to scsi_add_host() didn't happen. And that pattern happens to exist in some error paths, for example. Syzkaller causes that by using USB raw gadget device, error'ing on usb-storage driver, at usb_stor_probe2(). By checking that path, we can see that the BadDevice label leads to a scsi_host_put() after a SCSI host allocation, but there's no call to scsi_add_host() in such path. That leads to messages like this in dmesg (and a leak of the SCSI host proc structure): usb-storage 4-1:87.51: USB Mass Storage device detected proc_dir_entry 'scsi/usb-storage' already registered WARNING: CPU: 1 PID: 3519 at fs/proc/generic.c:377 proc_register+0x347/0x4e0 fs/proc/generic.c:376 The proper fix seems to still call scsi_proc_hostdir_rm() on dev_release(), but guard that with the state check for SHOST_CREATED; there is even a comment in scsi_host_dev_release() detailing that: such conditional is meant for cases where the SCSI host was allocated but there was no calls to {add,remove}_host(), like the usb-storage case. This is what we propose here and with that, the error path of usb-storage does not trigger the warning anymore.

Credit: 416baaa9-dc9f-4396-8d5f-8c081fb06d67 416baaa9-dc9f-4396-8d5f-8c081fb06d67

Affected SoftwareAffected VersionHow to fix
debian/linux
5.10.218-1
5.10.221-1
6.1.94-1
6.1.99-1
6.9.10-1
6.9.12-1
ubuntu/linux<5.4.0-189.209
5.4.0-189.209
ubuntu/linux<5.15.0-116.126
5.15.0-116.126
ubuntu/linux<6.8.0-35.35
6.8.0-35.35
ubuntu/linux<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-aws<5.4.0-1128.138
5.4.0-1128.138
ubuntu/linux-aws<5.15.0-1065.71
5.15.0-1065.71
ubuntu/linux-aws<6.8.0-1009.9
6.8.0-1009.9
ubuntu/linux-aws<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-aws-5.15<5.15.0-1065.71~20.04.1
5.15.0-1065.71~20.04.1
ubuntu/linux-aws-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-aws-5.4<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-aws-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-aws-fips<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-aws-hwe<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-azure<5.4.0-1133.140
5.4.0-1133.140
ubuntu/linux-azure<5.15.0-1068.77
5.15.0-1068.77
ubuntu/linux-azure<6.8.0-1008.8
6.8.0-1008.8
ubuntu/linux-azure<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-azure-4.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-azure-5.15<5.15.0-1068.77~20.04.1
5.15.0-1068.77~20.04.1
ubuntu/linux-azure-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-azure-5.4<5.4.0-1133.140~18.04.1
5.4.0-1133.140~18.04.1
ubuntu/linux-azure-5.4<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-azure-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-azure-fde<5.15.0-1068.77.1
5.15.0-1068.77.1
ubuntu/linux-azure-fde<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-azure-fde-5.15<5.15.0-1068.77~20.04.1.1
5.15.0-1068.77~20.04.1.1
ubuntu/linux-azure-fde-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-azure-fips<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-bluefield<5.4.0-1088.95
5.4.0-1088.95
ubuntu/linux-bluefield<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-fips<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gcp<5.4.0-1132.141
5.4.0-1132.141
ubuntu/linux-gcp<5.15.0-1064.72
5.15.0-1064.72
ubuntu/linux-gcp<6.8.0-1008.9
6.8.0-1008.9
ubuntu/linux-gcp<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gcp-4.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gcp-5.15<5.15.0-1065.73~20.04.1
5.15.0-1065.73~20.04.1
ubuntu/linux-gcp-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gcp-5.4<5.4.0-1132.141~18.04.1
5.4.0-1132.141~18.04.1
ubuntu/linux-gcp-5.4<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gcp-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gcp-fips<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gke<5.15.0-1062.68
5.15.0-1062.68
ubuntu/linux-gke<6.8.0-1004.7
6.8.0-1004.7
ubuntu/linux-gke<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gkeop<5.4.0-1095.99
5.4.0-1095.99
ubuntu/linux-gkeop<5.15.0-1048.55
5.15.0-1048.55
ubuntu/linux-gkeop<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-gkeop-5.15<5.15.0-1048.55~20.04.1
5.15.0-1048.55~20.04.1
ubuntu/linux-gkeop-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-hwe<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-hwe-5.15<5.15.0-116.126~20.04.1
5.15.0-116.126~20.04.1
ubuntu/linux-hwe-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-hwe-5.4<5.4.0-189.209~18.04.1
5.4.0-189.209~18.04.1
ubuntu/linux-hwe-5.4<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-hwe-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-ibm<5.4.0-1075.80
5.4.0-1075.80
ubuntu/linux-ibm<5.15.0-1058.61
5.15.0-1058.61
ubuntu/linux-ibm<6.8.0-1006.6
6.8.0-1006.6
ubuntu/linux-ibm<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-ibm-5.15<5.15.0-1058.61~20.04.1
5.15.0-1058.61~20.04.1
ubuntu/linux-ibm-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-ibm-5.4<5.4.0-1075.80~18.04.1
5.4.0-1075.80~18.04.1
ubuntu/linux-ibm-5.4<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-intel<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-intel-iotg<5.15.0-1060.66
5.15.0-1060.66
ubuntu/linux-intel-iotg<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-intel-iotg-5.15<5.15.0-1060.66~20.04.1
5.15.0-1060.66~20.04.1
ubuntu/linux-intel-iotg-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-iot<5.4.0-1040.41
5.4.0-1040.41
ubuntu/linux-iot<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-kvm<5.4.0-1116.123
5.4.0-1116.123
ubuntu/linux-kvm<5.15.0-1062.67
5.15.0-1062.67
ubuntu/linux-kvm<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-laptop<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-lowlatency<5.15.0-116.126
5.15.0-116.126
ubuntu/linux-lowlatency<6.8.0-35.35.1
6.8.0-35.35.1
ubuntu/linux-lowlatency<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-lowlatency-hwe-5.15<5.15.0-116.126~20.04.1
5.15.0-116.126~20.04.1
ubuntu/linux-lowlatency-hwe-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-lowlatency-hwe-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-lts-xenial<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-nvidia<5.15.0-1060.61
5.15.0-1060.61
ubuntu/linux-nvidia<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-nvidia-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-nvidia-6.8<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-nvidia-lowlatency<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-oem-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-oem-6.8<6.8.0-1006.6
6.8.0-1006.6
ubuntu/linux-oem-6.8<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-oracle<5.4.0-1127.136
5.4.0-1127.136
ubuntu/linux-oracle<5.15.0-1063.69
5.15.0-1063.69
ubuntu/linux-oracle<6.8.0-1006.6
6.8.0-1006.6
ubuntu/linux-oracle<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-oracle-5.15<5.15.0-1063.69~20.04.1
5.15.0-1063.69~20.04.1
ubuntu/linux-oracle-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-oracle-5.4<5.4.0-1127.136~18.04.1
5.4.0-1127.136~18.04.1
ubuntu/linux-oracle-5.4<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-oracle-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-raspi<5.4.0-1112.124
5.4.0-1112.124
ubuntu/linux-raspi<5.15.0-1058.61
5.15.0-1058.61
ubuntu/linux-raspi<6.8.0-1005.5
6.8.0-1005.5
ubuntu/linux-raspi<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-raspi-5.4<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-riscv<6.8.0-35.35.1
6.8.0-35.35.1
ubuntu/linux-riscv<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-riscv-5.15<5.15.0-1061.65~20.04.1
5.15.0-1061.65~20.04.1
ubuntu/linux-riscv-5.15<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-riscv-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-starfive<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-starfive-6.5<6.9~<6.8.3
6.9~
6.8.3
ubuntu/linux-xilinx-zynqmp<5.4.0-1047.51
5.4.0-1047.51
ubuntu/linux-xilinx-zynqmp<6.9~<6.8.3
6.9~
6.8.3

Never miss a vulnerability like this again

Sign up to SecAlerts for real-time vulnerability data matched to your software, aggregated from hundreds of sources.

Reference Links

Contact

SecAlerts Pty Ltd.
132 Wickham Terrace
Fortitude Valley,
QLD 4006, Australia
info@secalerts.co
By using SecAlerts services, you agree to our services end-user license agreement. This website is safeguarded by reCAPTCHA and governed by the Google Privacy Policy and Terms of Service. All names, logos, and brands of products are owned by their respective owners, and any usage of these names, logos, and brands for identification purposes only does not imply endorsement. If you possess any content that requires removal, please get in touch with us.
© 2024 SecAlerts Pty Ltd.
ABN: 70 645 966 203, ACN: 645 966 203