CVE-2024-35956: btrfs: qgroup: fix qgroup prealloc rsv leak in subvolume operations
First published: Mon May 20 2024(Updated: )
In the Linux kernel, the following vulnerability has been resolved: btrfs: qgroup: fix qgroup prealloc rsv leak in subvolume operations Create subvolume, create snapshot and delete subvolume all use btrfs_subvolume_reserve_metadata() to reserve metadata for the changes done to the parent subvolume's fs tree, which cannot be mediated in the normal way via start_transaction. When quota groups (squota or qgroups) are enabled, this reserves qgroup metadata of type PREALLOC. Once the operation is associated to a transaction, we convert PREALLOC to PERTRANS, which gets cleared in bulk at the end of the transaction. However, the error paths of these three operations were not implementing this lifecycle correctly. They unconditionally converted the PREALLOC to PERTRANS in a generic cleanup step regardless of errors or whether the operation was fully associated to a transaction or not. This resulted in error paths occasionally converting this rsv to PERTRANS without calling record_root_in_trans successfully, which meant that unless that root got recorded in the transaction by some other thread, the end of the transaction would not free that root's PERTRANS, leaking it. Ultimately, this resulted in hitting a WARN in CONFIG_BTRFS_DEBUG builds at unmount for the leaked reservation. The fix is to ensure that every qgroup PREALLOC reservation observes the following properties: 1. any failure before record_root_in_trans is called successfully results in freeing the PREALLOC reservation. 2. after record_root_in_trans, we convert to PERTRANS, and now the transaction owns freeing the reservation. This patch enforces those properties on the three operations. Without it, generic/269 with squotas enabled at mkfs time would fail in ~5-10 runs on my system. With this patch, it ran successfully 1000 times in a row.
Credit: 416baaa9-dc9f-4396-8d5f-8c081fb06d67 416baaa9-dc9f-4396-8d5f-8c081fb06d67
| Affected Software | Affected Version | How to fix |
|---|---|---|
| debian/linux | <=5.10.223-1<=6.1.106-3<=6.1.112-1 | 6.10.11-1 6.10.12-1 |
Never miss a vulnerability like this again
Sign up to SecAlerts for real-time vulnerability data matched to your software, aggregated from hundreds of sources.
Reference Links
- https://git.kernel.org/stable/c/14431815a4ae4bcd7c7a68b6a64c66c7712d27c9
- https://git.kernel.org/stable/c/6c95336f5d8eb9ab79cd7306d71b6d0477363f8c
- https://git.kernel.org/stable/c/74e97958121aa1f5854da6effba70143f051b0cd
- https://launchpad.net/bugs/cve/CVE-2024-35956
- https://git.kernel.org/linus/74e97958121aa1f5854da6effba70143f051b0cd
- https://security-tracker.debian.org/tracker/CVE-2024-35956
- https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-35956
- https://nvd.nist.gov/vuln/detail/CVE-2024-35956
- https://ubuntu.com/security/CVE-2024-35956
- agent/severity
- agent/title
- agent/type
- collector/nvd-api
- source/NVD
- collector/epss-latest
- source/FIRST
- agent/epss
- collector/nvd-cve
- collector/launchpad-cve
- source/Launchpad
- agent/author
- agent/remedy
- agent/description
- agent/first-publish-date
- agent/references
- collector/mitre-cve
- source/MITRE
- agent/last-modified-date
- agent/event
- agent/tags
- collector/security-tracker-debian
- source/Debian
- agent/software-canonical-lookup
- agent/softwarecombine
- collector/usn-cve
- source/Ubuntu
- package-manager/debian