CVE-2024-40912: wifi: mac80211: Fix deadlock in ieee80211_sta_ps_deliver_wakeup()
First published: Fri Jul 12 2024(Updated: )
In the Linux kernel, the following vulnerability has been resolved: wifi: mac80211: Fix deadlock in ieee80211_sta_ps_deliver_wakeup() The ieee80211_sta_ps_deliver_wakeup() function takes sta->ps_lock to synchronizes with ieee80211_tx_h_unicast_ps_buf() which is called from softirq context. However using only spin_lock() to get sta->ps_lock in ieee80211_sta_ps_deliver_wakeup() does not prevent softirq to execute on this same CPU, to run ieee80211_tx_h_unicast_ps_buf() and try to take this same lock ending in deadlock. Below is an example of rcu stall that arises in such situation. rcu: INFO: rcu_sched self-detected stall on CPU rcu: 2-....: (42413413 ticks this GP) idle=b154/1/0x4000000000000000 softirq=1763/1765 fqs=21206996 rcu: (t=42586894 jiffies g=2057 q=362405 ncpus=4) CPU: 2 PID: 719 Comm: wpa_supplicant Tainted: G W 6.4.0-02158-g1b062f552873 #742 Hardware name: RPT (r1) (DT) pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : queued_spin_lock_slowpath+0x58/0x2d0 lr : invoke_tx_handlers_early+0x5b4/0x5c0 sp : ffff00001ef64660 x29: ffff00001ef64660 x28: ffff000009bc1070 x27: ffff000009bc0ad8 x26: ffff000009bc0900 x25: ffff00001ef647a8 x24: 0000000000000000 x23: ffff000009bc0900 x22: ffff000009bc0900 x21: ffff00000ac0e000 x20: ffff00000a279e00 x19: ffff00001ef646e8 x18: 0000000000000000 x17: ffff800016468000 x16: ffff00001ef608c0 x15: 0010533c93f64f80 x14: 0010395c9faa3946 x13: 0000000000000000 x12: 00000000fa83b2da x11: 000000012edeceea x10: ffff0000010fbe00 x9 : 0000000000895440 x8 : 000000000010533c x7 : ffff00000ad8b740 x6 : ffff00000c350880 x5 : 0000000000000007 x4 : 0000000000000001 x3 : 0000000000000000 x2 : 0000000000000000 x1 : 0000000000000001 x0 : ffff00000ac0e0e8 Call trace: queued_spin_lock_slowpath+0x58/0x2d0 ieee80211_tx+0x80/0x12c ieee80211_tx_pending+0x110/0x278 tasklet_action_common.constprop.0+0x10c/0x144 tasklet_action+0x20/0x28 _stext+0x11c/0x284 ____do_softirq+0xc/0x14 call_on_irq_stack+0x24/0x34 do_softirq_own_stack+0x18/0x20 do_softirq+0x74/0x7c __local_bh_enable_ip+0xa0/0xa4 _ieee80211_wake_txqs+0x3b0/0x4b8 __ieee80211_wake_queue+0x12c/0x168 ieee80211_add_pending_skbs+0xec/0x138 ieee80211_sta_ps_deliver_wakeup+0x2a4/0x480 ieee80211_mps_sta_status_update.part.0+0xd8/0x11c ieee80211_mps_sta_status_update+0x18/0x24 sta_apply_parameters+0x3bc/0x4c0 ieee80211_change_station+0x1b8/0x2dc nl80211_set_station+0x444/0x49c genl_family_rcv_msg_doit.isra.0+0xa4/0xfc genl_rcv_msg+0x1b0/0x244 netlink_rcv_skb+0x38/0x10c genl_rcv+0x34/0x48 netlink_unicast+0x254/0x2bc netlink_sendmsg+0x190/0x3b4 ____sys_sendmsg+0x1e8/0x218 ___sys_sendmsg+0x68/0x8c __sys_sendmsg+0x44/0x84 __arm64_sys_sendmsg+0x20/0x28 do_el0_svc+0x6c/0xe8 el0_svc+0x14/0x48 el0t_64_sync_handler+0xb0/0xb4 el0t_64_sync+0x14c/0x150 Using spin_lock_bh()/spin_unlock_bh() instead prevents softirq to raise on the same CPU that is holding the lock.
Credit: 416baaa9-dc9f-4396-8d5f-8c081fb06d67 416baaa9-dc9f-4396-8d5f-8c081fb06d67
| Affected Software | Affected Version | How to fix |
|---|---|---|
| Linux Linux kernel | >=3.14<4.19.317 | |
| Linux Linux kernel | >=4.20<5.4.297 | |
| Linux Linux kernel | >=5.5<5.10.221 | |
| Linux Linux kernel | >=5.11<5.15.162 | |
| Linux Linux kernel | >=5.16<6.1.95 | |
| Linux Linux kernel | >=6.2<6.6.35 | |
| Linux Linux kernel | >=6.7<6.9.6 | |
| Linux Linux kernel | =6.10-rc1 | |
| Linux Linux kernel | =6.10-rc2 | |
| redhat/kernel | <4.19.317 | 4.19.317 |
| redhat/kernel | <5.4.279 | 5.4.279 |
| redhat/kernel | <5.10.221 | 5.10.221 |
| redhat/kernel | <5.15.162 | 5.15.162 |
| redhat/kernel | <6.1.95 | 6.1.95 |
| redhat/kernel | <6.6.35 | 6.6.35 |
| redhat/kernel | <6.9.6 | 6.9.6 |
| redhat/kernel | <6.10 | 6.10 |
| debian/linux | 5.10.223-1 5.10.226-1 6.1.115-1 6.1.119-1 6.11.10-1 6.12.5-1 |
Never miss a vulnerability like this again
Sign up to SecAlerts for real-time vulnerability data matched to your software, aggregated from hundreds of sources.
Reference Links
- https://git.kernel.org/stable/c/28ba44d680a30c51cf485a2f5a3b680e66ed3932
- https://git.kernel.org/stable/c/44c06bbde6443de206b30f513100b5670b23fc5e
- https://git.kernel.org/stable/c/456bbb8a31e425177dc0e8d4f98728a560c20e81
- https://git.kernel.org/stable/c/47d176755d5c0baf284eff039560f8c1ba0ea485
- https://git.kernel.org/stable/c/9c49b58b9a2bed707e7638576e54c4bccd97b9eb
- https://git.kernel.org/stable/c/d90bdff79f8e40adf889b5408bfcf521528b169f
- https://git.kernel.org/stable/c/e51637e0c66a6f72d134d9f95daa47ea62b43c7e
- https://git.kernel.org/stable/c/e7e916d693dcb5a297f40312600a82475f2e63bc
- https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-40912
- https://nvd.nist.gov/vuln/detail/CVE-2024-40912
- https://launchpad.net/bugs/cve/CVE-2024-40912
- https://security-tracker.debian.org/tracker/CVE-2024-40912
- https://ubuntu.com/security/CVE-2024-40912
- https://git.kernel.org/linus/44c06bbde6443de206b30f513100b5670b23fc5e
- https://access.redhat.com/errata/RHSA-2024:5928
- https://access.redhat.com/errata/RHSA-2024:7001
- https://access.redhat.com/errata/RHSA-2024:7000
- https://bugzilla.redhat.com/show_bug.cgi?id=2297496
- agent/title
- agent/type
- collector/nvd-api
- source/NVD
- agent/software-canonical-lookup
- agent/severity
- agent/weakness
- agent/author
- agent/remedy
- agent/first-publish-date
- agent/references
- collector/redhat-bugzilla
- source/Red Hat
- alias/CVE-2024-40912
- agent/tags
- collector/usn-cve
- source/Ubuntu
- agent/event
- agent/description
- collector/nvd-cve
- collector/security-tracker-debian
- source/Debian
- agent/softwarecombine
- collector/mitre-cve
- source/MITRE
- agent/last-modified-date
- agent/trending
- vendor/linux
- canonical/linux linux kernel
- version/linux linux kernel/3.14
- version/linux linux kernel/4.20
- version/linux linux kernel/5.5
- version/linux linux kernel/5.11
- version/linux linux kernel/5.16
- version/linux linux kernel/6.2
- version/linux linux kernel/6.7
- version/linux linux kernel/6.10-rc1
- version/linux linux kernel/6.10-rc2
- package-manager/redhat
- package-manager/debian