CVE-2024-52308: Connecting to a malicious Codespaces via GH CLI could allow command execution on the user's computer
First published: Thu Nov 14 2024(Updated: )
### Summary A security vulnerability has been identified in GitHub CLI that could allow remote code execution (RCE) when users connect to a malicious Codespace SSH server and use the `gh codespace ssh` or `gh codespace logs` commands. ### Details The vulnerability stems from the way GitHub CLI handles SSH connection details when executing commands. When developers connect to remote Codespaces, they typically use a SSH server running within a devcontainer, often provided through the [default devcontainer image](https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/introduction-to-dev-containers#using-the-default-dev-container-configuration). GitHub CLI [retrieves SSH connection details](https://github.com/cli/cli/blob/30066b0042d0c5928d959e288144300cb28196c9/internal/codespaces/rpc/invoker.go#L230-L244), such as remote username, which is used in [executing `ssh` commands](https://github.com/cli/cli/blob/e356c69a6f0125cfaac782c35acf77314f18908d/pkg/cmd/codespace/ssh.go#L263) for `gh codespace ssh` or `gh codespace logs` commands. This exploit occurs when a malicious third-party devcontainer contains a modified SSH server that injects `ssh` arguments within the SSH connection details. `gh codespace ssh` and `gh codespace logs` commands could execute arbitrary code on the user's workstation if the remote username contains something like `-oProxyCommand="echo hacked" #`. The `-oProxyCommand` flag causes `ssh` to execute the provided command while `#` shell comment causes any other `ssh` arguments to be ignored. In `2.62.0`, the remote username information is being validated before being used. ### Impact Successful exploitation could lead to arbitrary code execution on the user's workstation, potentially compromising the user's data and system. ### Remediation and Mitigation 1. Upgrade `gh` to `2.62.0` 2. Exercise caution when using custom devcontainer images, prefer default or pre-built devcontainers from trusted sources.
Credit: security-advisories@github.com security-advisories@github.com
| Affected Software | Affected Version | How to fix |
|---|---|---|
| go/github.com/cli/cli | <2.62.0 | 2.62.0 |
| go/github.com/cli/cli/v2 | <=2.61.0 | 2.62.0 |
| GitHub CLI | <2.62.0 | |
| debian/gh | <=2.23.0+dfsg1-1<=2.46.0-1 |
Never miss a vulnerability like this again
Sign up to SecAlerts for real-time vulnerability data matched to your software, aggregated from hundreds of sources.
Reference Links
- https://github.com/cli/cli/security/advisories/GHSA-p2h2-3vg9-4p87
- https://nvd.nist.gov/vuln/detail/CVE-2024-52308
- https://pkg.go.dev/vuln/GO-2024-3269
- https://github.com/advisories/GHSA-p2h2-3vg9-4p87 (Advisory)
- https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-52308
- https://launchpad.net/bugs/cve/CVE-2024-52308
- https://security-tracker.debian.org/tracker/CVE-2024-52308
- https://ubuntu.com/security/CVE-2024-52308
- https://github.com/cli/cli/commit/6d5a26cfd194e261e11015506c357d175fa4946a
- https://github.com/cli/cli/commit/a02f84528a43d7cb5e68bf7060e7b7abeecb00ee
- agent/weakness
- agent/first-publish-date
- agent/title
- agent/type
- agent/author
- collector/mitre-cve
- source/MITRE
- collector/nvd-cve
- source/NVD
- collector/github-advisory-latest
- source/GitHub
- alias/GHSA-p2h2-3vg9-4p87
- alias/CVE-2024-52308
- agent/software-canonical-lookup
- agent/severity
- agent/last-modified-date
- collector/nvd-api
- agent/software-canonical-lookup-request
- collector/github-advisory
- agent/references
- collector/security-tracker-debian
- source/Debian
- agent/softwarecombine
- agent/tags
- collector/usn-cve
- source/Ubuntu
- agent/description
- agent/event
- agent/trending
- package-manager/go
- vendor/github
- canonical/github cli
- package-manager/debian