CWE
476
Advisory Published
Updated

CVE-2024-56593: wifi: brcmfmac: Fix oops due to NULL pointer dereference in brcmf_sdiod_sglist_rw()

First published: Fri Dec 27 2024(Updated: )

In the Linux kernel, the following vulnerability has been resolved: wifi: brcmfmac: Fix oops due to NULL pointer dereference in brcmf_sdiod_sglist_rw() This patch fixes a NULL pointer dereference bug in brcmfmac that occurs when a high 'sd_sgentry_align' value applies (e.g. 512) and a lot of queued SKBs are sent from the pkt queue. The problem is the number of entries in the pre-allocated sgtable, it is nents = max(rxglom_size, txglom_size) + max(rxglom_size, txglom_size) >> 4 + 1. Given the default [rt]xglom_size=32 it's actually 35 which is too small. Worst case, the pkt queue can end up with 64 SKBs. This occurs when a new SKB is added for each original SKB if tailroom isn't enough to hold tail_pad. At least one sg entry is needed for each SKB. So, eventually the "skb_queue_walk loop" in brcmf_sdiod_sglist_rw may run out of sg entries. This makes sg_next return NULL and this causes the oops. The patch sets nents to max(rxglom_size, txglom_size) * 2 to be able handle the worst-case. Btw. this requires only 64-35=29 * 16 (or 20 if CONFIG_NEED_SG_DMA_LENGTH) = 464 additional bytes of memory.

Credit: 416baaa9-dc9f-4396-8d5f-8c081fb06d67

Affected SoftwareAffected VersionHow to fix
Linux Kernel<5.4.287
Linux Kernel>=5.5<5.10.231
Linux Kernel>=5.11<5.15.174
Linux Kernel>=5.16<6.1.120
Linux Kernel>=6.2<6.6.66
Linux Kernel>=6.7<6.12.5
debian/linux<=5.10.223-1
5.10.234-1
6.1.129-1
6.1.128-1
6.12.21-1
debian/linux-6.1
6.1.129-1~deb11u1

Never miss a vulnerability like this again

Sign up to SecAlerts for real-time vulnerability data matched to your software, aggregated from hundreds of sources.

Frequently Asked Questions

  • What is the severity of CVE-2024-56593?

    CVE-2024-56593 is categorized as a moderate severity issue due to the potential for a NULL pointer dereference in the Linux kernel's brcmfmac component.

  • How do I fix CVE-2024-56593?

    To fix CVE-2024-56593, you should upgrade your Linux kernel to a version that includes the patch addressing this vulnerability.

  • What affected versions are vulnerable to CVE-2024-56593?

    CVE-2024-56593 affects Linux kernel versions prior to 5.4.287, between 5.5 and 5.10.231, between 5.11 and 5.15.174, between 5.16 and 6.1.120, between 6.2 and 6.6.66, and between 6.7 and 6.12.5.

  • What component of the Linux kernel is affected by CVE-2024-56593?

    The vulnerability CVE-2024-56593 specifically affects the brcmfmac component of the Linux kernel.

  • When was CVE-2024-56593 disclosed?

    CVE-2024-56593 was disclosed as part of a series of patches meant to address various issues in the Linux kernel.

Contact

SecAlerts Pty Ltd.
132 Wickham Terrace
Fortitude Valley,
QLD 4006, Australia
info@secalerts.co
By using SecAlerts services, you agree to our services end-user license agreement. This website is safeguarded by reCAPTCHA and governed by the Google Privacy Policy and Terms of Service. All names, logos, and brands of products are owned by their respective owners, and any usage of these names, logos, and brands for identification purposes only does not imply endorsement. If you possess any content that requires removal, please get in touch with us.
© 2025 SecAlerts Pty Ltd.
ABN: 70 645 966 203, ACN: 645 966 203