CVE-2024-57946: virtio-blk: don't keep queue frozen during system suspend
In the Linux kernel, the following vulnerability has been resolved:
virtio-blk: don't keep queue frozen during system suspend
Commit 4ce6e2db00de ("virtio-blk: Ensure no requests in virtqueues before deleting vqs.") replaces queue quiesce with queue freeze in virtio-blk's PM callbacks. And the motivation is to drain inflight IOs before suspending.
block layer's queue freeze looks very handy, but it is also easy to cause deadlock, such as, any attempt to call into bioqueueenter() may run into deadlock if the queue is frozen in current context. There are all kinds of ->suspend() called in suspend context, so keeping queue frozen in the whole suspend context isn't one good idea. And Marek reported lockdep warning[1] caused by virtio-blk's freeze queue in virtblkfreeze().
[1] https://lore.kernel.org/linux-block/ca16370e-d646-4eee-b9cc-87277c89c43c@samsung.com/
Given the motivation is to drain in-flight IOs, it can be done by calling freeze & unfreeze, meantime restore to previous behavior by keeping queue quiesced during suspend.
Other sources
This CVE was automatically created from a reference found in an email or other text. If you are reading this, then this CVE entry is probably erroneous, since this text should be replaced by the official CVE description automatically.
— Launchpad
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
debian/linuxto a version that resolves this vulnerability.Fixed in 5.10.234-1Fixed in 6.1.129-1Fixed in 6.1.135-1Fixed in 6.12.27-1 - Upgrade
Upgrade
debian/linux-6.1to a version that resolves this vulnerability.Fixed in 6.1.129-1~deb11u1 - Upgrade
Upgrade to a fixed release to a version that resolves this vulnerability.
Fixed in 5.15.176.3-3 - Upgrade
Upgrade to a fixed release to a version that resolves this vulnerability.
Fixed in 6.6.78.1-3 - Upgrade
Upgrade
Linux kernel virtio-blkto a version that resolves this vulnerability.Patch 4ce6e2db00de - Configuration
Change virtio-blk suspend PM callback behavior to keep the virtqueue quiesced during suspend instead of keeping it frozen for the entire suspend context; implement the fix described as 'virtio-blk: don't keep queue frozen during system suspend' (Commit 4ce6e2db00de).
virtio-blk PM callbacks (system suspend) queue handling mode during suspend = replace queue freeze with queue quiesce/keep queue quiesced during suspend (previous behavior)
Event History
Frequently Asked Questions
What is the severity of CVE-2024-57946?
CVE-2024-57946 has not been assigned a CVSS score, but it showcases a critical oversight in queue management during system suspend in the Linux kernel.
How do I fix CVE-2024-57946?
To remediate CVE-2024-57946, update your Linux kernel to the latest patch version that addresses this vulnerability.
What versions of the Linux kernel are affected by CVE-2024-57946?
CVE-2024-57946 affects specific versions of the Linux kernel that implement virtio-blk functionality, particularly prior to the fix release.
What are the potential impacts of CVE-2024-57946?
CVE-2024-57946 could potentially lead to data loss or corruption during system suspension due to improper handling of queued requests.
Is there a workaround for CVE-2024-57946?
As a workaround for CVE-2024-57946, consider avoiding system suspensions until a patch can be applied.