CVE-2025-21939: drm/xe/hmm: Don't dereference struct page pointers without notifier lock
In the Linux kernel, the following vulnerability has been resolved:
drm/xe/hmm: Don't dereference struct page pointers without notifier lock
The pnfs that we obtain from hmmrangefault() point to pages that we don't have a reference on, and the guarantee that they are still in the cpu page-tables is that the notifier lock must be held and the notifier seqno is still valid.
So while building the sg table and marking the pages accesses / dirty we need to hold this lock with a validated seqno.
However, the lock is reclaim tainted which makes sgalloctablefrompagessegment() unusable, since it internally allocates memory.
Instead build the sg-table manually. For the non-iommu case this might lead to fewer coalesces, but if that's a problem it can be fixed up later in the resource cursor code. For the iommu case, the whole sg-table may still be coalesced to a single contigous device va region.
This avoids marking pages that we don't own dirty and accessed, and it also avoid dereferencing struct pages that we don't own.
v2: - Use assert to check whether hmm pfns are valid (Matthew Auld) - Take into account that large pages may cross range boundaries (Matthew Auld)
v3: - Don't unnecessarily check for a non-freed sg-table. (Matthew Auld) - Add a missing upread() in an error path. (Matthew Auld)
(cherry picked from commit ea3e66d280ce2576664a862693d1da8fd324c317)
Affected Software
Event History
Frequently Asked Questions
What is the severity of CVE-2025-21939?
CVE-2025-21939 is classified as a medium-severity vulnerability in the Linux kernel.
How do I fix CVE-2025-21939?
To mitigate CVE-2025-21939, update the Linux kernel to the latest patched version provided by your distribution.
What impact does CVE-2025-21939 have on system security?
CVE-2025-21939 may lead to unauthorized access or potential system instability due to improper handling of page pointers.
Is CVE-2025-21939 exploitable remotely?
The exploitability of CVE-2025-21939 depends on system configuration, but it primarily affects local users.
When was CVE-2025-21939 disclosed?
CVE-2025-21939 was disclosed as part of ongoing security improvements in the Linux kernel.