CVE-2026-113732: virtualenv activate.fish runs commands from a path or prompt with a backslash before a quote
Impact
FishActivator defines no quote(), so it inherits ViaTemplateActivator.quote, which returns shlex.quote(string). That function follows POSIX sh rules, where a backslash inside single quotes stays a literal character. fish reads \' inside single quotes as an escaped quote and \\ as an escaped backslash. A value with a backslash before a quote therefore ends the literal somewhere other than where shlex.quote put the end, and fish expands the command substitution that follows.
The environment path reaches set -gx VIRTUALENV, and --prompt or VIRTUALENVPROMPT reaches set -gx VIRTUALENVPROMPT. For --prompt "x\'\$(touch PWNED)'\'", the generated activate.fish contains:
fish set -gx VIRTUALENVPROMPT 'x\'"'"'$(touch PWNED)'"'"'\'"'"''
source bin/activate.fish runs touch PWNED, and fish prints no error. The same payload as a directory name runs through VIRTUALENV. --prompt . takes the current directory's name, so running virtualenv inside a directory someone else named is enough. Without the backslash the payload runs nothing, and under bash it runs nothing either.
virtualenv generates activate.fish by default. An attacker needs to influence the environment path or prompt: a CI job or wrapper tool that passes a branch, project or job name through, or a directory in a cloned repository or unpacked archive.
The bug affects every release up to 21.14.1 that ships activate.fish. The GHSA-p58f-9548-mpm2 fix in 21.7.13 moved the placeholders outside their quotes but kept shlex.quote.
Patches
Fixed in 21.14.2. activate.fish now escapes backslashes and single quotes the way fish reads them, so the example above runs nothing and shows the prompt as given. Fix: https://github.com/pypa/virtualenv/commit/3bddeaf8d02c3ee7f576503efb082f8f494cfcab
Workarounds
Do not create an environment whose path or prompt contains a backslash, and inspect activate.fish before you source one you did not create.
Credits
Kevin Stubbings (@Kwstubbs) of GitHub Security Lab reported this issue.
Other sources
virtualenv is a tool for creating isolated virtual python environments. Prior to 21.14.2, FishActivator inherits ViaTemplateActivator.quote(), which uses POSIX shlex.quote() even though fish interprets backslashes and single quotes differently. An attacker-influenced environment path, --prompt, or VIRTUALENVPROMPT value containing a backslash before a quote can therefore terminate the generated fish literal and execute command substitution when the user sources activate.fish. This issue is fixed in version 21.14.2.
— Ubuntu
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
pip/virtualenvto a version that resolves this vulnerability.Fixed in 21.14.2 - Upgrade
Upgrade
bitnami/virtualenvto a version that resolves this vulnerability.Fixed in 21.14.2 - Upgrade
Upgrade
debian/python-virtualenvto a version that resolves this vulnerability.Fixed in 21.15.6+ds-2 - Upgrade
Upgrade to a fixed release to a version that resolves this vulnerability.
Fixed in 21.14.2 - Compensating control
Do not create a virtual environment whose path or prompt contains a backslash before a quote.
- Compensating control
Inspect activate.fish before sourcing one you did not create.
Event History
Frequently Asked Questions
Who is exposed to this issue?
Users of virtualenv versions earlier than 21.14.2 who use the fish shell and source a generated activate.fish script are exposed when the environment path, --prompt value, or VIRTUALENV_PROMPT value is attacker-influenced and contains a backslash immediately before a quote.
What must an attacker control to exploit it?
The attacker must be able to influence the virtual environment path, the --prompt option, or the VIRTUALENV_PROMPT value used when generating the activation script. Exploitation also requires a user to source the resulting activate.fish script in fish.
Are other activation shells affected by the described flaw?
The issue described is specific to FishActivator and the generated activate.fish script. The vulnerable behavior comes from using POSIX shlex.quote() despite fish handling backslashes and single quotes differently.
How can I remediate the issue?
Upgrade virtualenv to version 21.14.2 or later. If upgrading is not immediately possible, avoid sourcing activate.fish scripts generated from attacker-influenced environment paths or prompt values, especially values containing a backslash before a quote.
How can I determine whether a generated activation script is risky?
Review the inputs used to generate it: the environment path, --prompt value, and VIRTUALENV_PROMPT. A script is at risk when one of those attacker-influenced values contains a backslash immediately before a quote and the script is sourced by fish.