CVE-2026-74591: mm/filemap: __filemap_add_folio() restore index before retrying
In the Linux kernel, the following vulnerability has been resolved:
mm/filemap: filemapaddfolio() restore index before retrying
In filemapaddfolio()'s split-a-conflict loop, xassetorder() is applied repeatedly: each application modifies xas.xaindex, rounding it down according to the splitorder attempted at that stage: and if all goes as intended, it eventually (or immediately) converges on an xastrysplit() to the required folioorder, with xas.xaindex now the same as index: then xasstore() puts the new folio into the xarray there.
But if a new node was needed, and GFPNOWAIT allocation did not get one, the lock is dropped, xasnomem() used to allocate, and sequence retried. If (that part of) the xarray is unchanged when the lock is reacquired, no problem. But what if the conflict was meanwhile resolved by another thread (perhaps even doing the same thing, inserting a folio at that same index)? Isn't there a danger of now putting our folio into the xarray at an intermediate rounded-down index? With !foliocontains() bug to follow, when CONFIGDEBUGVM=y is checking for that.
Fix this with an xassetorder() to restore the original xas.xaindex at the bottom of the loop, so the retry does a full re-evaluation after reacquiring the lock, and cannot reach xasstore() with the wrong index.
Production was suffering from rare SIGILLs and SIGSEGVs, executable text found a page away from where it belonged, !foliocontains() bug hit when debug enabled: symptoms not seen since this patch went in.
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
ubuntu/linux-hwe-7.0to a version that resolves this vulnerability.Fixed in 7.0.0-42.42~24.04.1 - Upgrade
Upgrade
ubuntu/linux-riscv-7.0to a version that resolves this vulnerability.Fixed in 7.0.0-42.42.1~24.04.1 - Upgrade
Upgrade
ubuntu/linuxto a version that resolves this vulnerability.Fixed in 7.0.0-42.42 - Upgrade
Upgrade
ubuntu/linux-awsto a version that resolves this vulnerability.Fixed in 7.0.0-1016.17 - Upgrade
Upgrade
ubuntu/linux-gcpto a version that resolves this vulnerability.Fixed in 7.0.0-1016.18 - Upgrade
Upgrade
ubuntu/linux-ibmto a version that resolves this vulnerability.Fixed in 7.0.0-1017.17 - Upgrade
Upgrade
ubuntu/linux-oem-7.0to a version that resolves this vulnerability.Fixed in 7.0.0-1017.17 - Upgrade
Upgrade
ubuntu/linux-oracleto a version that resolves this vulnerability.Fixed in 7.0.0-1015.16 - Upgrade
Upgrade
ubuntu/linux-riscvto a version that resolves this vulnerability.Fixed in 7.0.0-42.42.1
Event History
Frequently Asked Questions
What conditions are needed for the incorrect xarray index to be used?
The split-a-conflict path must need a new xarray node, fail to obtain it with GFP_NOWAIT, drop the lock for xas_nomem() allocation, and then retry after another thread has resolved the conflict. In that case, the retry could retain an intermediate rounded-down index unless the original index is restored.
How might this issue be detected during testing?
With CONFIG_DEBUG_VM enabled, the kernel can detect the resulting inconsistency through a !folio_contains() check. The description does not provide a detection method for builds without CONFIG_DEBUG_VM.