CVE-2026-89557: md: do overflow check for sb->bblog_shift in super_1_load()
In the Linux kernel, the following vulnerability has been resolved:
md: do overflow check for sb->bblogshift in super1load()
In super1load(), sb->bblogshift is an u8 type value loaded from on- disk superblock. It is used for badblocks API badblocksset() by the following sequence,
1930 rdev->badblocks.shift = sb->bblogshift; 1931 for (i = 0 ; i < (sectors << (9-3)) ; i++, bbp++) { 1932 u64 bb = le64tocpu(bbp); 1933 int count = bb & (0x3ff); 1934 u64 sector = bb >> 10; 1935 sector <<= sb->bblogshift; 1936 count <<= sb->bblogshift; 1937 if (bb + 1 == 0) 1938 break; 1939 if (!badblocksset(&rdev->badblocks, sector, count, 1)) 1940 return -EINVAL; 1941 }
bb->bblogshit is in range of 0-255, variable sector is 64bit width, for an invalid bb->bblogshit, it is possible to make sector be overflowed by the following calculation, 1935 sector <<= sb->bblogshift; Then in turn when call badblocksset() at line 1939 with the invalid rdev->badblocks.shift set at line 1930, may result an overflow inside badblocksclear() in block/badblocks.c.
Although there are many places to call badblocks APIs, the non-zero shift value is only used in super1load(), other places always use 0 as the shift value. Therefore it is unnecessary to do a general shift value overflow check inside badblock API, and just check here as the caller.
This may avoid unnecessary check, make the badblocks API code more simple and elegant.
Affected Software
Event History
Frequently Asked Questions
What condition triggers the vulnerable path?
The path is reached when super_1_load() reads sb->bblog_shift from an on-disk superblock and uses it to shift bad-block sector and count values. An invalid shift value can overflow the 64-bit sector calculation and can subsequently cause an overflow in _badblocks_clear() through badblocks_set().
Is this behavior used by other badblocks API callers?
The description states that non-zero badblocks shift values are only used in super_1_load(). Other callers of the badblocks APIs use a shift value of zero.