GHSA-8mxv-9xhp-86h4: Infoleak
1. Summary
The S3 redirect callback strips X-Amz-Security-Token when a redirect changes scheme or host, but it does not strip IBM IAM bearer authorization or customer-provided encryption keys. Two independently validated paths remain:
- a same-host HTTPS-to-HTTP redirect preserves Authorization: Bearer ... and exposes a reusable IBM IAM token to the plaintext network path; - a cross-origin redirect preserves SSE-C and copy-source SSE-C key headers.
The High rating is driven by the reusable IBM IAM bearer token. The SSE-C cross-origin disclosure is a secondary confidentiality issue. The meaningful threat is a trusted endpoint, gateway, or accelerator that emits an unsafe redirect, followed by an adjacent/on-path observer; describing the originally configured endpoint itself as the attacker would be weak because that endpoint already receives the request secrets.
2. Affected Assets & Attack Surface
- S3 redirect policy: backend/s3/s3.go:1345-1379 - IBM IAM signer: backend/s3/ibmsigner.go:28-40 - SSE-C key preparation: backend/s3/s3.go:1821-1837 - Affected operations: requests carrying IBM IAM authorization, SSE-C keys, or copy-source SSE-C keys - Confirmed affected version: <= v1.74.0-240-ga0c09f138
3. Technical Root Cause Analysis
s3CheckRedirect applies a one-header denylist:
go if s3RedirectCrossesHost(req, via) { req.Header.Del("X-Amz-Security-Token") }
Go removes Authorization on some hostname changes, but preserves it for a same-host redirect and does not treat a scheme downgrade as sufficient reason to remove it. Go also has no generic knowledge that the SSE-C headers contain raw encryption keys. The rclone callback recognizes the STS token but not these additional origin-bound secrets.
4. Proof-of-Concept & Evidence
Using the actual redirect callback:
1. An HTTPS endpoint redirected to HTTP on the same hostname. 2. The plaintext destination received the planted IBM bearer token and SSE-C headers. 3. A separate redirect to an unrelated hostname caused Go to remove Authorization, but the destination still received both SSE-C key headers. 4. In both cases, rclone removed the planted STS token, proving that the S3-specific callback executed while omitting the other secret classes.
The related GHSA-gx4c-2hqx-cw2r covers the STS downgrade path and confirms that rclone treats scheme changes as a credential boundary. It does not cover the IBM bearer or SSE-C variants retained here.
5. Impact Assessment
A captured IBM bearer token can authorize reads, writes, and deletes within its IAM scope. A disclosed SSE-C key can expose corresponding ciphertext available to the recipient; copy-source keys can expose protected source objects. The exact impact is limited by token policy and the attacker's access to encrypted objects.
6. Remediation Guidance
- Reject every HTTPS-to-HTTP redirect before replay. - Do not automatically follow secret-bearing cross-origin redirects. - On any scheme, host, or effective-port change, remove all authorization, cookies, session tokens, SSE-C fields, copy-source SSE-C fields, and provider-specific credentials. - Where redirects are required, allowlist exact destinations and reconstruct/re-sign a new request. - Add redirect tests for every secret header class and for scheme, hostname, subdomain, and port changes.
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
go/github.com/rclone/rcloneto a version that resolves this vulnerability.Fixed in 1.75.0 - Upgrade
Upgrade
rcloneto a version that resolves this vulnerability.Fixed in v1.74.0-240-ga0c09f138 - Configuration
Implement the S3 redirect safeguards: (1) Do not automatically follow secret-bearing cross-origin redirects for requests carrying IBM IAM authorization, SSE-C keys, or copy-source SSE-C keys. (2) Reject every HTTPS-to-HTTP redirect before replay. (3) Where redirects are required, allowlist exact destinations and reconstruct/re-sign a new request instead of reusing the original secrets. (4) On any scheme, host, or effective-port change, remove all authorization, cookies, session tokens, SSE-C fields, copy-source SSE-C fields, and provider-specific credentials.
rclone S3 redirect handling s3RedirectPolicy = do not automatically follow secret-bearing cross-origin redirects; reject HTTPS-to-HTTP redirect before replay; allowlist exact destinations and reconstruct/re-sign a new request - Configuration
Ensure that when a redirect causes an on-any scheme, host, or effective-port change, rclone removes authorization and provider-specific credentials, including IBM IAM bearer authorization (backend/s3/ibm_signer.go:28-40).
rclone IBM IAM signer (backend/s3/ibm_signer.go:28-40) redirect-secret-stripping = strip Authorization (IBM IAM bearer) on scheme/host/effective-port changes; never preserve IBM IAM authorization across unsafe redirects - Configuration
Ensure SSE-C key headers and copy-source SSE-C key headers are removed on any scheme, host, or effective-port change and are not preserved across cross-origin redirects (backend/s3/s3.go:1821-1837 and S3 redirect policy backend/s3/s3.go:1345-1379).
rclone SSE-C key preparation (backend/s3/s3.go:1821-1837) ssec-redirect-stripping = strip SSE-C key headers and copy-source SSE-C key headers on scheme/host/effective-port changes; do not preserve these headers on cross-origin redirects