GHSA-hc8v-wwc9-vgxm: High severity go/github.com/go-git/go-git/v6 vulnerability
Impact
A symlink traversal issue in go-git could allow worktree operations to modify files outside the intended worktree path.
The worktreeFilesystem wrapper rejected dangerous path strings, including paths containing .git, parent-directory components, or control characters. However, it did not prevent filesystem operations from following symbolic links that were already present in the worktree.
As a result, a path that is safe when evaluated as a string could still resolve into the repository's Git metadata directory. For example, if s is a symbolic link to .git, writing to s/config would modify .git/config.
A symbolic link at the final path component could also be followed. For example, if s points directly to .git/config, opening s for writing with truncation could overwrite the repository configuration.
Exploitation requires an attacker to be able to introduce or control a symbolic link in the worktree and cause the application to perform a write through that path.
Applications using storage/memory for their Storer, or go-billy/memfs for their Worktree, are not affected by this vulnerability.
Patches
The issue has been addressed by making the worktree filesystem wrapper a symlink-safe boundary.
Worktree operations now reject paths where an existing symbolic link in any path component could cause the operation to escape the intended worktree location, including symbolic links at the final component.
Users of filesystem-backed worktrees should upgrade to a patched version.
Credits
Thanks to @kodareef5 for reporting this issue and working with the go-git security team toward its resolution. :1stplacemedal: We would also like to thank @HughLewis20, who independently reported the same issue while a fix was already in progress.
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
go/github.com/go-git/go-git/v6to a version that resolves this vulnerability.Fixed in 6.0.0-alpha.5 - Upgrade
Upgrade
go/github.com/go-git/go-git/v5to a version that resolves this vulnerability.Fixed in 5.19.2
Event History
Frequently Asked Questions
What is the severity of GHSA-hc8v-wwc9-vgxm?
The severity of GHSA-hc8v-wwc9-vgxm is rated high with a score of 7.1.
What impact does GHSA-hc8v-wwc9-vgxm have?
GHSA-hc8v-wwc9-vgxm can allow symlink traversal, potentially permitting worktree operations to modify files outside the intended worktree path.
How do I fix GHSA-hc8v-wwc9-vgxm?
To fix GHSA-hc8v-wwc9-vgxm, you should update to the latest version of the go-git library that contains the necessary security patches.
Which versions of go-git are affected by GHSA-hc8v-wwc9-vgxm?
GHSA-hc8v-wwc9-vgxm affects go-git versions v5 and v6.
What mitigation strategies are recommended for GHSA-hc8v-wwc9-vgxm?
Mitigation for GHSA-hc8v-wwc9-vgxm includes validating and sanitizing input paths to avoid dangerous strings that could lead to symlink traversal.