GHSA-jwrc-gm9j-263p: Medium severity pip/jupyterlite-core vulnerability

Description

A Markdown file or a notebook output can carry a button that runs a JupyterLab command. Since 4.5.7 the first click on such a button opens a prompt naming the command, with Cancel, Run Once and Trust. Choosing Trust runs the command and marks the document trusted, so its later buttons run without a prompt.

Which document gets marked is decided when the user answers, not when they click. Both trust commands read whichever document is current at that moment: markdownviewer:trust uses tracker.currentWidget, and notebook:trust uses the equivalent lookup. If another document becomes current while the prompt is open, that document is the one marked trusted, and the one the user was looking at stays untrusted.

Users are affected if all of the following are true:

- they run JupyterLab 4.5.7 through 4.6.3, or an application that bundles it such as Notebook 7.5+; - they open a Markdown file or notebook from someone else and click a button in it; - they answer Trust rather than Cancel or Run Once; and - a second document becomes the current one while the prompt is open, for example through a workspace restoring at startup, an extension activating a widget, or a command that opens a file

Impact

The user loses control over which document they trusted. Every button in the document that was (incorrectly) marked as trusted runs from then on without a prompt, so if that document also came from an untrusted source, its buttons fire on a single click with no confirmation. That is the state the prompt was added to prevent, in GHSA-mqcg-5x36-vfcg.

The command that ran had the user's consent, because the prompt named it and they pressed Trust. The document they were reading stays untrusted, so it prompts again on the next click.

Notebooks are written to disk

When the document marked is a notebook, the effect outlives the browser session. notebook:trust marks every cell trusted and then saves the file, which results in the server signing it, so the notebook stays trusted when it is next opened. The save also writes out any unsaved edits in that notebook. A second confirmation appears first, but it says only that a trusted notebook may execute hidden code, without naming the file, so it does not show the user which notebook is about to be trusted.

A Markdown preview marked this way stays trusted only until it is closed. Nothing is written to disk.

Patches

JupyterLab v4.6.4 and v4.5.11 contain the patch. The trust request now carries the document that was clicked, and the command is run only once that same document has been marked.

Users of applications that depend on JupyterLab, such as Notebook v7+, should update jupyterlab package too.

Workarounds

Given the high complexity of a potential exploit, we advise treating this as a defense in-depth and update at earliest opportunity, rather than apply the workarounds listed below. However, for users running in highly sensitive environments who are unable to upgrade the workarounds are included below.

Turn off command linker, which removes the ability to execute frontend commands altogether:

json { "@jupyterlab/apputils-extension:sanitizer": { "allowCommandLinker": false } }

In such configuration the buttons in Markdown files and notebook outputs then do nothing when clicked. Documentation and extensions that use command links for navigation stop working, and the setting applies to every document, not only untrusted ones.

If disabling that setting is not desirable and update is not possible, advise users to choose "Run Once" rather than "Trust". "Run Once" makes the command run but no document is marked, so nothing can be trusted in error.