GHSA-p944-4xh2-x776: Infoleak

Summary

docling accepts serialized DoclingDocument JSON as an input format (InputFormat.JSONDOCLING, enabled by default). A crafted JSON file can set a picture's image uri to a local file path. When the converted document is exported with embedded images (ImageRefMode.EMBEDDED, the CLI default for Markdown and HTML), the referenced file is read and embedded as base64 in the output.

Details

docling/backend/json/doclingjsonbackend.py validates the JSON into a DoclingDocument without checking image references. The file is then read by docling-core:

- DoclingDocument.withembeddedpictures opens file:// and plain-path URIs with PIL. - ImageRef.pilimage checks allowimagefileuri for file:// URIs but not for plain Path values. docling's picture enrichment models load images through this property.

Only files that PIL can decode as an image are disclosed. Other files, such as text files or keys, fail to decode and are not embedded. The different error behaviour does reveal whether a path exists.

Impact

Disclosure of image files readable by the converting process (for example other users' uploads or page images in a shared service), and disclosure of whether a local path exists.

Proof of concept

python from pathlib import Path from doclingcore.types.doc import DoclingDocument, ImageRef from doclingcore.types.doc.base import Size

doc = DoclingDocument(name="poc") doc.addpicture(image=ImageRef(mimetype="image/png", dpi=72, size=Size(width=1, height=1), uri=Path("/srv/uploads/other-user/scan.png"))) doc.saveasjson("poc.json")

docling poc.json --to md embeds the referenced PNG as base64 in poc.md.

Patches

Fixed in docling 2.131.0 by #4417. The Docling JSON backend now drops image references that point at local files (paths, file: URIs and any scheme other than data: and http(s)) and logs a warning. Callers that need to load local images from JSON they trust can opt in with DoclingJSONFormatOption(backendoptions=DeclarativeBackendOptions(enablelocalfetch=True)); the CLI has no such option.

Code that loads untrusted JSON directly with docling-core (DoclingDocument.loadfromjson) and exports it with embedded images is not covered by this fix; that part is tracked in docling-core.

Workarounds

Upgrade to 2.131.0. For older versions:

- Remove InputFormat.JSONDOCLING from allowedformats when converting untrusted input. - Export with ImageRefMode.PLACEHOLDER or ImageRefMode.REFERENCED instead of EMBEDDED.