GHSA-r6p4-grq7-xm4m: Medium severity pip/wagtail vulnerability
Impact Due to a missing permission check on the image preview endpoint, a user with access to the Wagtail admin can preview any image. The existing data of the image object itself is not exposed. The vulnerability is not exploitable by an ordinary site visitor without access to the Wagtail admin.
Patches Patched versions have been released as Wagtail 7.0.8, 7.3.3, 7.4.2.
Workarounds For sites that cannot easily upgrade to a current supported version, the vulnerability can be patched by adding the following code to urls.py URL pattern declarations to override the vulnerable view.
python from django.core.exceptions import PermissionDenied from django.shortcuts import getobjector404 from django.urls import path from wagtail.admin import urls as wagtailadminurls from wagtail.images.permissions import permissionpolicy from wagtail.images.views import preview
def patchedpreview(request, imageid, filterspec): image = getobjector404(getimagemodel(), id=imageid)
if not permissionpolicy.userhaspermissionforinstance(request.user, "change", image): raise PermissionDenied
return preview(request, imageid, filterspec)
urlpatterns = [ # Example where the CMS admin is at /admin/. # Add this before the Wagtail admin URLs registration, with the same sub-path. path("admin/images/<int:imageid>/preview/<str:filterspec>/", patchedpreview) path("admin/", include(wagtailadminurls)), ]
Acknowledgements Many thanks to @0x1saac and @harshakshit for reporting this issue.
For more information If you have any questions or comments about this advisory:
Visit Wagtail's support channels Email us at security@wagtail.org (view our security policy for more information).
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
pip/wagtailto a version that resolves this vulnerability.Fixed in 7.4.2 - Upgrade
Upgrade
pip/wagtailto a version that resolves this vulnerability.Fixed in 7.3.3 - Upgrade
Upgrade
pip/wagtailto a version that resolves this vulnerability.Fixed in 7.0.8 - Upgrade
Upgrade
wagtailto a version that resolves this vulnerability.Fixed in 7.0.8 - Upgrade
Upgrade
wagtailto a version that resolves this vulnerability.Fixed in 7.3.3 - Upgrade
Upgrade
wagtailto a version that resolves this vulnerability.Fixed in 7.4.2 - Configuration
For sites that cannot easily upgrade, add the provided patched code to urls.py URL pattern declarations to override the vulnerable image preview view: (1) define patched_preview that checks permission_policy.user_has_permission_for_instance(request.user, "change", image) and raises PermissionDenied if not allowed; (2) include the Wagtail admin urls with the same sub-path (shown as "admin/"); (3) register the patched preview route: path("admin/images/<int:image_id>/preview/<str:filter_spec>/", patched_preview).
Wagtail (Django urls.py URL pattern declarations) URL pattern for the image preview endpoint = Add a URL override that routes /admin/images/<int:image_id>/preview/<str:filter_spec>/ to a patched_preview view and enforces a permission check.
Event History
Frequently Asked Questions
Who can exploit this issue?
An attacker must have access to the Wagtail admin. Ordinary site visitors without Wagtail admin access cannot exploit it.
What information can be exposed?
A Wagtail admin user can preview any image despite missing permission checks. Existing data on the image object itself is not exposed.
Which releases contain the fix?
Patched releases are Wagtail 7.0.8, 7.3.3, and 7.4.2.
What can be done if an upgrade is not immediately possible?
The vulnerable preview view can be overridden in urls.py with a patched view that checks whether the requesting user has change permission for the specific image before allowing the preview.