GHSA-vmgj-9cwm-cf3h: XSS
Summary The color field accepts any string that begins with a valid rgb() / hsl() color, because TinyColor.isValid does not anchor its match at the end of the string. An authenticated user with edit rights can store arbitrary HTML after a valid color prefix. When the stored value is rendered , the payload executes, resulting in stored XSS.
Details Server-side validation of the color field relies on TinyColor:
js const { TinyColor } = require('@ctrl/tinycolor'); if (!new TinyColor(value).isValid) throw self.apos.error('invalid');
TinyColor's rgb/hsl matchers are not anchored at the end of the string, while hex matchers are. Tested with @ctrl/tinycolor
| Input | isValid | |---|---| | rgb(1,2,3)<img src=x onerror=alert(1)> | true | | rgb(1,2,3)</textarea><script>alert(1)</script> | true | | hsl(0,100%,50%);--x:1}</style><script>alert(1)</script> | true | | #ff0000<img src=x onerror=alert(1)> | false |
The value is saved to MongoDB unchanged (not normalized to hex8).
Relation to GHSA-97v6-998m-fp4g GHSA-97v6 addressed CSS custom property injection escaping a <style> context. The root cause (validation that accepts trailing content after a valid color) still exists in <= 4.32.2, so [FILL IN: either "the style-tag sink remains exploitable via </style>" OR "a separate HTML sink at X is exploitable"]. Fixing the validation (requiring the full string to be a color, or storing only TinyColor's normalized output) would close both.
Impact Any user with edit permission can plant persistent JavaScript that runs in the browser of visitors and administrators viewing the affected page, enabling session hijacking and actions as an admin.
Suggested fix Reject values unless the entire string is a valid color, e.g. normalize on save: js const c = new TinyColor(value); if (!c.isValid) throw self.apos.error('invalid'); value = c.toHex8String(); // store only normalized output
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
npm/apostropheto a version that resolves this vulnerability.Fixed in 4.34.0 - Configuration
Anchor validation to the end of the input so trailing HTML/JavaScript is rejected; alternatively normalize on save with c.toHex8String() and store only the normalized output.
Server-side color field validation using @ctrl/tinycolor color input validation/storage = Reject values unless the entire string is a valid color, or store only TinyColor's normalized hex8 output
Event History
Frequently Asked Questions
Who can exploit this issue?
An authenticated user with edit rights can exploit it by saving a crafted value in the affected color field. Exploitation also requires a victim to render the stored value, at which point the injected payload executes.
Which color formats are affected by the validation bypass?
Values beginning with a valid rgb() or hsl() expression can include arbitrary trailing HTML and still be accepted. Hex values with trailing HTML, such as #ff0000 followed by an image payload, are rejected by the tested validation.
Is the malicious value altered before storage?
No. The supplied value is saved to MongoDB unchanged and is not normalized to a hex8 color value.