GHSA-wrvw-254r-wpmv: OS Command Injection
Impact An OS command injection vulnerability exists in the PowerShell and Cmd shell wrappers provided by the CliInvoke.Specializations package (the PowershellProcessInvoker/CmdProcessInvoker invokers, and the UsePowerShell/UseCmd middleware in v3 pre-release versions).
The wrappers re-run a caller-supplied target and arguments inside a shell command (pwsh -Command ... / cmd /c ...). In affected versions the wrapped command was delivered to the operating system as a single ProcessStartInfo.Arguments string. The OS command-line parser re-tokenizes that string before the shell parses it, so a double quote (") in the target or arguments breaks OS-level quoting and lets the wrapped shell reassemble a second, unintended command.
An attacker could exploit this to execute arbitrary commands with the privileges of the host process.
Patches The Specializations Packages now deliver the command via ProcessStartInfo.ArgumentList (natively where supported, and polyfilled in older TFMs), so that the operating system passes argv verbatim and only the shell parses the command once.
Upgrade to: - 2.8.5 (2.8.x line) - 2.9.4 (2.9.x line) - 2.10.5 (2.10.x line) - 3.0.0-beta.1 (3.x pre-release line)
Workarounds No complete workaround is available. Until upgraded:
- Reject or strip " from any target path or argument passed to the PowerShell/Cmd wrappers. On 2.2.0 – 2.9.2 and 3.0.0-alpha.1 – alpha.4, also reject shell metacharacters (;, |, &, $, backtick, parentheses). - Alternatively, bypass the wrappers for untrusted input and invoke the target process directly so that no second shell parse of the data occurs.
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Upgrade
Upgrade
nuget/AlastairLundy.CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 2.0.2 - Upgrade
Upgrade
nuget/CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 3.0.0-beta.1 - Upgrade
Upgrade
nuget/CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 2.10.5 - Upgrade
Upgrade
nuget/CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 2.9.4 - Upgrade
Upgrade
nuget/CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 2.8.5 - Upgrade
Upgrade
CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 2.10.5 - Upgrade
Upgrade
CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 2.8.5 - Upgrade
Upgrade
CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 2.9.4 - Upgrade
Upgrade
CliInvoke.Specializationsto a version that resolves this vulnerability.Fixed in 3.0.0-beta.1 - Compensating control
Until upgraded, bypass the PowerShell/Cmd wrappers for untrusted input and invoke the target process directly so the data is not subjected to a second shell parse.
- Compensating control
Until upgraded, reject or strip double quotes (") from target paths or arguments passed to the PowerShell/Cmd wrappers; for versions 2.2.0–2.9.2 and 3.0.0-alpha.1–alpha.4, also reject shell metacharacters (;, |, &, $, backtick, and parentheses).
Event History
Frequently Asked Questions
Which uses of the package are affected?
Applications are exposed when they use the PowerShell or Cmd shell wrappers, specifically PowershellProcessInvoker or CmdProcessInvoker. In v3 pre-release versions, UsePowerShell and UseCmd middleware are also affected.
What input must an attacker control to exploit this?
An attacker needs influence over the target command or its arguments passed to a vulnerable wrapper. A double quote in that supplied value can break the operating-system-level quoting and cause the shell to execute an unintended second command.
What privileges would injected commands receive?
Injected commands execute with the privileges of the host process running the vulnerable wrapper. The impact therefore depends on the permissions assigned to that process.
How should affected deployments be remediated?
Upgrade the Specializations package to a patched release in the applicable supported line, including 2.8.5 for 2.8.x, 2.9.4 for 2.9.x, or 2.10.5 for 2.10.x. The patched packages use ProcessStartInfo.ArgumentList so the operating system receives arguments verbatim rather than re-tokenizing a single argument string.