REDHAT-BUG-2547374: High severity Foreman Smart Proxy Dynflow Core vulnerability
Proxy::Dynflow::Core.webconsole mounts the Dynflow web console at /dynflow/console and, when consoleauth is true (the default), calls doauthorizewithsslclient only. That helper rejects an empty SSLCLIENTCERT and does not compare the certificate subject with trustedhosts or the certificate serial with acceptedcertserial. The serial is still computed in Core#initialize, with a comment that only the proxy’s own certificate should be trusted, and nothing reads it.
Before the merge, smartproxydynflowcore’s authorizewithsslclient halted unless the client serial matched the proxy certificate (added in commit 444cc84, Ivan Necas, 2016-06-20, “to avoid being able to use any valid certificate”). Commit e205e19 (2021-06-03) switched the console to the proxy-wide helper and dropped that comparison. First release carrying the drop is 0.4.0. The installer text for consoleauth says it enables trusted hosts and SSL. The code does not check trusted hosts.
The console is the Dynflow 2.x web UI (dynflow >= 1.6, < 3). Its index lists every execution plan. The step view runs YAML.dump on action input and output with no redaction. A remote-execution action input includes the script, hostname, effective user, and the secrets hash (sshpassword, keypassphrase, effectiveuserpassword) when those are set. The same before filter covers POST /:id/resume, POST /:id/cancel, POST /:id/skip/:stepid, and POST /:id/cancel/:stepid. Resume requires a paused plan. Skip requires a paused plan and a failed step. Cancel works when the plan or step is cancellable.
The proxy listens with SSLVerifyClient = VERIFYPEER and without FAILIFNOPEERCERT, so a missing certificate still completes the handshake and then fails this check. A presented certificate must chain to sslcafile. On Satellite that file is the Katello CA, which also issues content-host consumer certificates, so a registered host that is not in trustedhosts passes. consoleauth: false removes the check. The dynflow plugin listens on HTTPS by default. The proxy HTTP port is off by default (foremanproxy::http defaults to false). If HTTP is enabled, this SSL check does not run.
Current puppet default for the dynflow database is in-memory. Plans remain until the execution-plan cleaner (default 30 minutes) or a proxy restart. Secrets of in-flight and recent jobs are in the console during that window.
Affected Software
Remediation
Recommended actions to resolve this vulnerability, in priority order.
- Configuration
Keep console_auth enabled so the web console performs the SSL client-certificate authorization check; setting console_auth to false removes the check.
Proxy::Dynflow::Core web console console_auth = true - Configuration
Keep the proxy HTTP port disabled, because the SSL authorization check does not run when HTTP is enabled.
Foreman proxy HTTP listener foreman_proxy::http = false
Event History
Frequently Asked Questions
Is the default console authentication configuration sufficient to restrict access to trusted hosts?
No. Although console_auth is enabled by default and its installer text describes trusted-host and SSL protection, the console authorization path only rejects an empty SSL_CLIENT_CERT. It does not compare the certificate subject to trusted_hosts or its serial number to accepted_cert_serial.
What does an attacker need to access the console?
The authorization helper requires a non-empty client certificate. The console path does not require that certificate’s subject to match a trusted host or its serial number to match the proxy certificate or accepted certificate serial.
Which deployments should be reviewed?
Review Smart Proxy Dynflow Core deployments using a release carrying the change; 0.4.0 is the first release identified as including it. The affected web UI is the Dynflow 2.x console used with dynflow versions from 1.6 up to, but not including, 3.
What information could console access reveal?
The console index lists all execution plans. Its step view serializes action input and output using YAML.dump without redaction; remote-execution action input can include the script.